Try to improve the performance of rendering many empty paragraphs #44606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -104 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
kevin940726
force-pushed
the
fix/1000-empty-paragraphs-performance
branch
from
1b78359 to
039286a
Compare
talldan
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
The block select performance tests for #42722 showed:
- trunk: '103.58 ms'
- Allow dropping an image on an empty paragraph block to create an image block #42722: '477.16 ms'
And this PR is showing:
- trunk: '722.35 ms'
- Try to improve the performance of rendering many empty paragraphs #44606: '96.7 ms'
So it seems like this should return things to the level they were before.
It tests well too, so I'd be happy to see this merged and then it should be possible to verify the performance results when there's more data
|
Checking again though, some other metrics are lower now: |
|
Seems like this current approach won't work cause it will mark every paragraph element as a "drop zone", which somehow breaks the other drag-and-drop feature. I'll try to find out if there's another way. |
Is it because I guess it would still be possible to conditionally set the |
|
Made obsolete by #44647. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A follow-up to #42722 to improve the select performance when rendering a large number of empty paragraphs at the same time.
Why?
How?
Testing Instructions
Screenshots or screencast