File, Search Blocks: Lower CSS specificity #41393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
added
[Block] File
|
Size Change: -701 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
draganescu
reviewed
May 27, 2022
mikachan
approved these changes
May 30, 2022
draganescu
requested changes
May 31, 2022
There was a problem hiding this comment.
🧇 great! @MaggieCabrera can we add a comment for
* + .wp-block-file__button and :where(.wp-block-search__button-inside .wp-block-search__inside-wrapper) explaining how we want to lower specificity and for what reason? Given someone may come back to this months later it's easy to no understand what's up with this solution.
Similar to how we do here in the paragraph block.
|
I´m not changing |
annezazu
added
the
CSS Styling
bph
added
the
Needs Dev Note
|
Could the Search block's wrapper have a higher specificity? As noted on Trac 60164, the old CSS reset removed border and padding on any Using two elements could be enough: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Lowers the CSS specificity for the File and Search Block selectors
Why?
The high specificity of these selectors are overriding the newest addition to the elements API (the buttons), pointed out here and here.
How?
I'm trying to remove unneeded selectors and used :where when I wasn't sure about what I could remove without breaking other stuff
Testing Instructions
I've tested this using emptytheme, with the following markup:
And in the theme.json file I have this:
Screenshots or screencast
With the theme.json changes:
Without the theme.json changes:
/cc @WordPress/block-themers