Use wp_query when the query is set to inherited

[huubl]

What?

Use the actual wp_query when 'inherit query' in the query block is set.

Ps. I think this can't be merged as these lines are there probably for a reason. So maybe it should be fixed an other way.

Why?

When setting 'inherit query' in the query block it's not using the actual wp_query. This gives problems in some cases. For example current_post is not inherited and showing as -1.

Maybe fixing this too:
#39285

How?

Testing Instructions

1. Use Twenty Twenty-Two + Gutenberg plugin
2. Make a page and set it as 'Posts page' in settings > reading. Add the Query Loop Block with 'inherit query' set to the page.
3. Add this to functions.php:

add_filter('render_block', function(string $block_content, array $block, WP_Block $instance) {
	// PS. is using empty($instance->context) the right way to target the actual post items?
	if ('core/post-template' === $block['blockName'] && empty($instance->context)) {
		global $wp_query;
		$block_content .= 'current_post: '.$wp_query->current_post;
	}

	return $block_content;
}, 20, 3);

4. Watch output.

Screenshots or screencast

--

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @huubl! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[ntsekouras]

Thanks for the pr @huubl! There are a couple of issues with the inherit option and I'm trying to better understand the problems and a good path forwards. This is quite related to this PR about sticky options.

At first I'd like to understand what problems you're facing with the current approach. You mention:

This gives problems in some cases. For example current_post is not inherited and showing as -1.

current_post is available only during The Loop and the current changes doesn't seem to affect anything. That value is updated later in the loop. Does your PR fixes your use case? If yes, can you elaborate a bit on the use case?

What other challenges are you facing?

I think the big issue we're having with Query Loop and inherit is that while some controls are hidden in the UI, their values are preserved and I observed that while testing with at least orderby - this value is not set in the global query. We need to have no arbitrary results from block query attributes and what we expect when we set inherit to true.

Maybe we should inherit all options from global query but maybe there are some other concerns.. @draganescu had mentioned some nuances in the sticky use cases that I'm also planning to look into more..

[huubl]

Hi @ntsekouras. Thank you for looking into this.

Does your PR fixes your use case? If yes, can you elaborate a bit on the use case?

Yes, this pull request solves my use case. I need to build an irregular layout for posts. I build a custom (ACF) post block and use $wp_query->current_post to change the markup and image size depending on index of the post.

What other challenges are you facing?

I thought I had issues when using the pre_get_posts action, unfortunately can't reproduce them. But I can imagine there can be more related issues, like the PR you mention and maybe this issue.

We need to have no arbitrary results from block query attributes and what we expect when we set inherit to true.

I agree. A thought: Isn't it possible to alter wp_query early on with the desired block query attributes added somehow (like pre_get_posts)? This way the wp_query is used with the possibility to change e.g. orderby according to the block query attribute. Plus it saves an extra query.

[huubl]

Fixed by:
#40656

[desrosj]

@huubl While collecting props and credits for 6.1, it seems you are one of a few dozen folks that have not connected their WordPress.org account to their GitHub profile.

Could you share your WordPress.org account so that we can ensure you're properly credited on the About page for WordPress 6.1? Connecting your accounts will also help those collecting this in the future. Thanks in advance!