Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns: Allow patterns within patterns to render in Block Preview #40794

Closed
wants to merge 2 commits into from
Closed

Patterns: Allow patterns within patterns to render in Block Preview #40794

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e84a47
#39732 Fixed a bug that caused settings.__experimentalBlockPatterns t…
inc2734 May 3, 2022
c0b6b38
Merge branch 'trunk' into fix/pattern-not-rendered-in-blockpreview
inc2734 May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/block-editor/src/components/block-preview/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ export function BlockPreview( {
);
const settings = useMemo( () => {
const _settings = { ...originalSettings };
_settings.__experimentalBlockPatterns = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @inc2734.

It looks like this was intentionally added to avoid parsing patterns in block previews - #29444 (comment).

Unfortunately, I'm not familiar with this part of the code, so maybe folks who reviewed the original PR can help us out. Cc @mcsf, @ntsekouras

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @inc2734! @Mamaduka is right about the reasoning for this line of code. We should try to find some different solution here.

return _settings;
}, [ originalSettings ] );
const renderedBlocks = useMemo( () => castArray( blocks ), [ blocks ] );
Expand Down