-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add constants file to Spacer block #40446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Enhancement
A suggestion for improvement.
[Block] Spacer
Affects the Spacer Block
labels
Apr 19, 2022
Size Change: -10 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Apr 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
geriux
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
SiobhyB
pushed a commit
that referenced
this pull request
Apr 26, 2022
4 tasks
priethor
added
[Type] Code Quality
Issues or PRs that relate to code quality
and removed
[Type] Enhancement
A suggestion for improvement.
labels
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Spacer
Affects the Spacer Block
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a constants file to the Spacer block.
Why?
This PR originates as a follow-up of this comment.
How?
Creates a constants file (i.e.
constants.js
) and adds theMIN_SPACER_SIZE
constant, so it can be accessed from both web and native versions of the Spacer block.Testing Instructions
Web version (instructions extracted from #39577)
Native version (instructions extracted from #40053)
Screenshots or screencast
N/A