Add constants file to Spacer block #40446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Enhancement
|
Size Change: -10 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
SiobhyB
pushed a commit
that referenced
this pull request
Apr 26, 2022
4 tasks
priethor
added
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a constants file to the Spacer block.
Why?
This PR originates as a follow-up of this comment.
How?
Creates a constants file (i.e.
constants.js) and adds theMIN_SPACER_SIZEconstant, so it can be accessed from both web and native versions of the Spacer block.Testing Instructions
Web version (instructions extracted from #39577)
Native version (instructions extracted from #40053)
Screenshots or screencast
N/A