Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Display a Button Appender when Buttons block is empty #38337

Closed
wants to merge 3 commits into from

Conversation

aurooba
Copy link
Member

@aurooba aurooba commented Jan 28, 2022

Based on a Twitter conversation with @heathergray (closes #38338), it looks like the lack of a visual cue that the Buttons block is still in the editor, seems to cause confusion for more than one person. Although, upon refreshing the Buttons block auto populates with an empty Button block, it can be frustrating not realizing that deleting the Button block doesn't mean you've deleted the Buttons parent block.

Description

To solve this issue, I've changed the Buttons block just slightly, to show the Button Appender when the block is empty, making it easy to see that the Buttons block is still in the editor, you can easily select it to delete/add/etc.

Testing Instructions

  1. Open up the Block Editor
  2. Add a Buttons block
  3. Delete all Button blocks
  4. See the appender appear when the Buttons block is empty.

Screenshots

Screen.Recording.2022-01-28.at.10.37.30.AM.mov

Types of changes

When empty, the Buttons block displays the Button Appender to indicate its existence.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a highlight border around empty parent blocks
2 participants