Fix alignment of the "Delete template" button in the post editor #37450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
the
[Feature] Template Editing Mode
|
Size Change: +13 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
Thanks for fixing this, @jameskoster. P.S. I also see the overflow-y. It would be nice to fix this issue as well. Maybe a separate PR or here. Screenshot
|
|
Nice one! However, I wonder if we can't remove that rule at the source, rather than override it here? The rule appears to be redundant now: I.e. find the |
|
@jasmussen it crossed my mind, but I wasn't aware of the context for that @Mamaduka good spot! Seems to be an issue with custom negative margins in this particular UI. I'll fix that now. |
|
If we can, we could definitely fix (remove) the rules at the source. It's a modicum of more testing but it's a nice code quality win. |
|
The min-width seems to be a result of #34532 I'm not sure we should remove that? 🤔 |
Mamaduka
added
[Type] Bug
7 tasks
|
Closing in favor of #37442 |
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a tiny patch this one. The
min-widthapplied to menu items was causing an odd text alignment issue in the Delete Template button.