Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the WP_Theme_JSON_Resolver_Gutenberg class to be like the core one #36974

Merged
merged 2 commits into from
Nov 29, 2021

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Nov 29, 2021

Related WordPress/wordpress-develop#1967

This PR makes sure that the contents of the Gutenberg's lib/class-wp-theme-json-resolver-gutenberg.php and WordPress core wp-includes/class-wp-theme-json-resolver.php are the same, so it's easier to compare them and the backports require minimal manual intervention.

@oandregal oandregal self-assigned this Nov 29, 2021
@oandregal oandregal added [Type] Code Quality Issues or PRs that relate to code quality Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Nov 29, 2021
@oandregal
Copy link
Member Author

It's not necessary to backport this PR to WordPRess core, because it brings changes from there. However, we need to backport it to Gutenberg's wp/trunk branch.

/**
* Registers a Custom Post Type to store the user's origin config.
*/
public static function register_user_custom_post_type() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been extracted to lib/compat/wordpress-5.9/register-global-styles-cpt.php

@oandregal oandregal merged commit 8e0957c into trunk Nov 29, 2021
@oandregal oandregal deleted the update/theme-json-resolver-class branch November 29, 2021 22:18
@github-actions github-actions bot added this to the Gutenberg 12.1 milestone Nov 29, 2021
@noisysocks noisysocks removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants