Full Site Editing: Remove block template resolution unit tests #36855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ockham Should we track that falsy test (bug) somewhere. |
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
youknowriad
approved these changes
Nov 25, 2021
I'll file an issue! |
|
The PR needs to be rebased, there are now conflicts after merging #36647 |
ockham
force-pushed
the
remove/template-resolution-algorithm-unit-tests
branch
from
bea9c79 to
6a92e5b
Compare
|
Rebased. |
Since the issue is now in Core, I've filed a ticket in Core Trac: https://core.trac.wordpress.org/ticket/54515. |
7 tasks
noisysocks
pushed a commit
that referenced
this pull request
Dec 6, 2021
These tests have now been backported to Core, see WordPress/wordpress-develop#1920, so they're no longer needed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per discussion here: #36647 (comment)
These tests have now been backported to Core, see WordPress/wordpress-develop#1920, so they're no longer needed here.
Note that they also actually contained a test that was falsely negative -- it was only discovered in the process of backporting that the test setup in GB was faulty. This means that it also makes sense to delete the tests from GB in order to remove a false sense of confidence in them.
How has this been tested?
Verify that CI goes green.