[Patterns]: Add a flag to hide patterns from UI #36108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Feature] Themes
ntsekouras
requested review from
mcsf,
youknowriad,
mtias,
kjellr,
jffng and
a team
ntsekouras
commented
Nov 1, 2021
| hideFromUI: true, | ||
| content: | ||
| '<!-- wp:test-block-a --><!-- /wp:test-block-a -->', | ||
| }, |
There was a problem hiding this comment.
The above was added just to verify that the current behavior is not affected by patterns with inserter flag set to false.
youknowriad
reviewed
Nov 1, 2021
| __experimentalGetParsedPattern( state, name ) | ||
| ); | ||
| const parsedPatterns = patterns | ||
| .filter( ( { hideFromUI } ) => ! hideFromUI ) |
There was a problem hiding this comment.
I do wonder whether hideFormUI is the right name for it. Maybe at some point we'd want to show patterns in the UI somewhere but not in the inserter. Anyway, maybe we should just base it on how we do it for blocks. So (inserter: false or supports.inserter: false)
There was a problem hiding this comment.
I don't have strong opinion on this and I can change it. I just named it this way, as by using inserter made me think the Inserter (main+quick) where there might be more places that we do no want these patterns displayed like the pattern explorer modal (if it lands 😄 ).
|
Size Change: -78 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #36084
Previously there was an implementation to control where patterns should appear with a
scopeproperty (similar to block variations), which was discussed and decided to be removed and every pattern should be shown in inserter. The context for that was for patterns used in the experimentalBlockPatternSetupcomponent, which can suggest patterns in a Placeholder - seeQuery Loop.Now with Pattern block merged, themes can create patterns for dealing with some issues like internationalized content etc.. and a similar flag for hiding such patterns is needed.
In this PR I decided to add a
inserterflag and make the filtering with this flag directly in__experimentalGetAllowedPatternswhich is used in every place that we need to handle patterns and show them in UI. Patterns with the flag set totruecan still be retrieved individually by__experimentalGetParsedPattern.Testing instructions
'inserter' => falseand observe that is not shown in any UI with pattern handling, like the inserter or theBlockPatternSetup.Patternblock by using a pattern with this flag and verify that is working properly and is not shown in any UI, like the Inserter