Remove deprecated classnames from Navigation Link block #35358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
the
[Block] Submenu
|
There are some separate styles for the navigation editor that depend on those classnames which would also need to be updated: |
Replace .wp-block-navigation-link__label with .wp-block-navigation-item__label
|
Size Change: +1.23 kB (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
carolinan
requested review from
adamziel,
ajitbohra,
chrisvanpatten,
draganescu,
getdave,
kevin940726,
nerrad,
ntwb,
talldan and
tellthemachines
as code owners
tellthemachines
approved these changes
Oct 8, 2021
| @@ -51,7 +51,7 @@ The structural CSS for the navigation block targets generic classnames across me | |||
| - `.wp-block-navigation__submenu-container` is applied to submenus to main menu items. | |||
There was a problem hiding this comment.
Not sure what these docs about Nav block classnames are doing in the components package 🤔 they should be in the block folder instead. No need to fix that here though, I've created #35445 to address it separately.
carolinan
commented
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #35237, #35238
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).