Fix navigation editor missing appender not showing appender when no blocks selected #34678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
requested review from
adamziel,
ajitbohra,
draganescu,
ellatrix,
getdave,
kevin940726 and
tellthemachines
as code owners
talldan
commented
Sep 9, 2021
| const appender = | ||
| isSelected || | ||
| ( isImmediateParentOfSelectedBlock && ! selectedBlockHasDescendants ) | ||
| ? undefined |
There was a problem hiding this comment.
It turns out that InnerBlock.DefaultAppender isn't a thing, it resolves as undefined, so I've just put undefined here 😆
|
Size Change: +1.88 kB (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
talldan
commented
Sep 9, 2021
| } ) => { | ||
| return ( | ||
| <BaseButtonBlockAppender | ||
| className={ classnames( { | ||
| 'block-list-appender__toggle': isToggle, |
There was a problem hiding this comment.
There's some code smell with this classname, it was added to BlockListAppender at some point in the past, but it should really be part of the ButtonBlockAppender component. It's also missing the block-editor prefix. I'll work on a separate PR to fix it.
talldan
commented
Sep 9, 2021
Comment on lines
+169
to
+174
| .block-editor-block-list__block:not(.is-selected):not(.has-child-selected):not(.block-editor-block-list__layout) { | ||
| .block-editor-block-list__layout > .block-list-appender .block-list-appender__toggle { | ||
| opacity: unset; | ||
| transform: unset; | ||
| } | ||
| } |
There was a problem hiding this comment.
The block editor also has CSS to hide the appender, so that needs to be unset.
getdave
approved these changes
Sep 10, 2021
|
Thanks for the review! The styling improvements just merged in #34281 should fix the issue with the appender position. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #31276
This fix is frustratingly complex.
The main problem is that the navigation block has its own custom logic for appender visibility, which conflicts with the desired behavior for the navigation editor.
The secondary problem is that even without the navigation block's custom logic, the block editor's default appender wouldn't be displayed anyway. When all blocks are deselected the block editor would usually show an appender at the root level, but not if that root level is a locked template, which is the case in the navigation editor.
This PR fixes things by supplying a completely custom appender implementation to the Navigation Block—yet another place where the block is being extend by the editor.
But at least with this situation, the navigation editor is in complete control of when the appender is shown, and this logic can be changed to whatever is desired now, even the appearance of the appender could be changed.
How has this been tested?
Expected: the appender should still be visible
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).