components: Add deprecated props adapter for ColorPicker #34014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Type] Enhancement
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: +223 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Aug 12, 2021
packages/components/src/ui/color-picker/use-deprecated-props.ts
Outdated
Show resolved
Hide resolved
ciampo
reviewed
Aug 12, 2021
packages/components/src/ui/color-picker/use-deprecated-props.ts
Outdated
Show resolved
Hide resolved
ciampo
approved these changes
Aug 12, 2021
This was referenced Aug 25, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
useDeprecatedPropshook as well as a LegacyAdapter component that acts as a proxy for the new color picker and transforms the deprecated props into the new version of the props (while also allowing for the new props to be passed directly).How has this been tested?
Storybook. The existing story for the new color picker should continue to work (even though it is now using the LegacyAdapter). Likewise, the new story for the legacy adapter should work with all the features of the new color picker correctly working as well as the correct shape of the legacy color values being emitted in the "onChangeComplete" prop. Please refer to the
colorToStateincomponents/src/color-picker/utils.jsto double check the shape of the color picker change object.Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).