Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

WordPress / gutenberg Public

Notifications You must be signed in to change notification settings
Fork 4.3k
Star 10.7k

Code
Issues 5k+
Pull requests 1.5k
Discussions
Actions
Projects 8
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Security
Insights

Split control for URL and Text within Link UI#33849

Merged

noisysocks merged 63 commits intotrunkWordPress/gutenberg:trunkfrom try/link-control-split-url-textWordPress/gutenberg:try/link-control-split-url-textCopy head branch name to clipboard

Oct 26, 2021

+1,115-73

Conversation Commits63 (63)Checks Files changed

Commits

Commits on Oct 26, 2021

Implement basic mechanics and UI
getdave
committed
Grab the selected/link text to use in Link UI
getdave
committed
Try to update the existing value with the new link and text
getdave
committed
Retain existing formats when applying new link format
getdave
committed
Document scenarios for clarity
getdave
committed
Only show text control once a link has been committed
getdave
committed
Strip HTML from Link Preview
getdave
committed
Strip HTML from link text control
getdave
committed
Allow submission of text changes via enter key
getdave
committed
Ensure user provided text has length before commiting as label value
getdave
committed
Migrate to using existing title prop of LinkControl
getdave
committed
Undo overzealous stripping of HTML. Leave this to escape on output.
getdave
committed
No change to text should preserve all formatting
getdave
committed
Avoid complications of preserving existing formats when amending link text via LinkControl
getdave
committed
Expand boundary seek algorithm in order to fix bugs
getdave
committed
Abstract walking loops to functions
getdave
committed
Reduce and simplify boundary algorithm
getdave
committed
Avoid reassignment of startIndex and prefer self documenting variable
getdave
committed
Improve edge case handling and function naming
getdave
committed
Add initial unit tests for Text control
getdave
committed
Add tests for more edge cases
getdave
committed
Correct text naming
getdave
committed
Don't modify value internally.
getdave
committed
Add tests to ensure LinkControl does not modify the value's title property
getdave
committed
Have Nav Link block strip HTML formatting before passing to LinkControl
getdave
committed
Avoid passing new function ref for handleSubmit
getdave
committed
Remove outdated reference to text prop of value
getdave
committed
Add guard against empty label
getdave
committed
Move utils to utils to expose for testing purposes
getdave
committed
Slice target text +1 beyond the end of the format boundary
getdave
committed
Add tests for getFormatValue and adjust implementation to get correct bounds
getdave
committed
Augment tests for getFormatBoundary
getdave
committed
Fix bug whereby rich text value passed to LinkControl when no active link format present
getdave
committed
Extract function for retrieving RichTextValue for a given selection
getdave
committed
Add basic e2e tests for link text
getdave
committed
Add test for preservation of whitespace
getdave
committed
Add e2e test covering modification of link text via Link UI
getdave
committed
Ensure focus is reliably placed within Link UI
getdave
committed
Fix test name typo
getdave
committed
Standardise test nomenclature on "submit" not "commit"
getdave
committed
Restore avoiding focus on mount to ensure collapsed selection can be made
getdave
committed
Improve e2e test code comments to explain creation of a collapsed selection
getdave
committed
Remove duplicate test
getdave
committed
Add doc block to getFormatBoundary function
getdave
committed
Conditionally show the visible URL input label
getdave
committed
Remove magic numbers from submit button positioning
getdave
committed
Fix overflow bug introduced in earlier commit
getdave
committed
Remove stripHTML dependency and hand roll internal method
getdave
committed
Re-inline utility function to simplify.
getdave
committed
Reduce verbosity of walkToBoundary method
getdave
committed
Add doc block to walkToBoundary
getdave
committed
Refactor to reduce verbosity of getFormatBoundary
getdave
committed
Improve comments and self documentation of e2e test
getdave
committed
Remove unwanted comment
getdave
committed
Rename helper util to disambiguate from text input focus
getdave
committed
Refine e2e tests
getdave
committed
Rename an annotate unit tests
getdave
committed
Ensure boundary tests actually exercise code under test
getdave
committed
Refactor getFormatBoundary to handle more edge cases and put more of the code under test
getdave
committed
Fix to target icon based Edit button
getdave
committed
For currently active links use the full link text as the value of LinkControl ignoring any text selection
getdave
committed
Conform to style guide for coercion of Booleans
getdave
committed
Fix outdated test helper refs
getdave
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.