[RNMobile] Fix: Button button border-radius to be stored as a value + unit #33405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enejb
added
[Block] Buttons
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
2 tasks
enejb
changed the title
enejb
force-pushed
the
fix/button-radius-update
branch
from
1033beb to
de352b0
Compare
geriux
reviewed
Jul 14, 2021
There was a problem hiding this comment.
This is working well for me but as you mentioned it only takes into account px values, I created a Buttons block from the web editor using a different unit rem, then open it in the mobile editor, and the correct value shows but of course we are not showing that it's in rem. If we update that value then it's stored in pixels (as expected).
Question: This PR doesn't take into account the other possible units that we could add support for. (for example em, rem) Should we try to address that in this PR as well?
I guess it depends if we want to make it partially work or add the full functionality. Do we know if we want to have a fix for the latest mobile editor release?
I would expect us to add the full functionality for options that are available. |
7 tasks
|
I created another PR #33434 that adds the unit control to the button block |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#3723
Description
This PR adds the unit (px) value to the button radius attribute.
In #31483 the border radius allowed for other unit types.
Which meant that the border radius once saved in the mobile Gutenberg editor didn't show up as expected.
Question: This PR doesn't take into account the other possible units that we could add support for. (for example em, rem) Should we try to address that in this PR as well?
How has this been tested?
Screenshots
There are no visual changes.
Types of changes
Fixes the changes that broke in mobile.
Checklist:
*.native.jsfiles for terms that need renaming or removal).