Button block border: fix block validation issue for numeric border radius #33100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Block] Buttons
|
CC: @aaronrobertshaw — I wasn't sure if it was best for us to add a deprecation or ensure we can handle both cases from within the edit and save functions. Because we aren't changing the markup of the saved post content, I was leaning toward handling both cases, but happy to look into deprecations if you think that's a better approach to resolving this. |
|
Size Change: +77 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
|
I see there's a separate PR that looks at using the deprecation approach in #33117 — that one might be better to land than this one? |
7 tasks
|
Thanks for working on a fix for this @andrewserong, I'm wondering if the oversight I made actually occurred in #31483 rather than #33017. Fixing up the deprecations appears to be the best option so I'd vote we close this one in favour of #33117. |
|
Good call, thanks @aaronrobertshaw, I'll close this one out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #33017, it looks like we might have missed a particular case of the button block where the radius is set numerically. This resulted in the following block pattern throwing a block validation error:
Description
Following on from #33017, add back in a condition to use the numeric border radius attribute if present, otherwise use the border props styles.
How has this been tested?
Screenshots
After this change, the above should render correctly, e.g.
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).