components: Remove @emotion/css from Spacer
#33055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: +676 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
sarayourfriend
force-pushed
the
remove/emotion-css-spacer
branch
from
01cfdb3 to
38131d7
Compare
sarayourfriend
force-pushed
the
remove/emotion-css-spacer
branch
from
e048ec0 to
e805987
Compare
ciampo
approved these changes
Jul 2, 2021
Co-authored-by: Marco Ciampini <[email protected]>
ciampo
reviewed
Jul 5, 2021
There was a problem hiding this comment.
Changing the order in which the margin and padding props are applied caused a snapshot test "error", which highlighted a side effect of this change.
Apart from updating the snapshot, we should also look for every usage of <Spacer /> and see if the margin/marginX/marginY/padding/paddingX/paddingY props are specified and are expected to override any "single" top/right/bottom/left value — as that wouldn't be the case anymore with the changes from this PR.
Lucky there are no usages of the component 🙂 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #30503 (comment)
I also added a story to make it easier to test.
How has this been tested?
Test it out in Storybook. All the props should work as expected.
Types of changes
Non breaking change
Checklist:
*.native.jsfiles for terms that need renaming or removal).