-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
components: Restrict imports of @emotion/css #33051
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
June 28, 2021 20:35
sarayourfriend
changed the title
Add/deprecate emotion css
Restrict imports of @emotion/css
Jun 28, 2021
Size Change: 0 B Total Size: 1.05 MB ℹ️ View Unchanged
|
sarayourfriend
force-pushed
the
add/deprecate-emotion-css
branch
from
June 28, 2021 20:44
87e758f
to
cf52f3d
Compare
sarayourfriend
added
[Feature] Component System
WordPress component system
[Package] Components
/packages/components
[Tool] ESLint plugin
/packages/eslint-plugin
labels
Jun 28, 2021
sarayourfriend
changed the title
Restrict imports of @emotion/css
components: Restrict imports of @emotion/css
Jun 28, 2021
tyxla
approved these changes
Jun 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍 LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Component System
WordPress component system
[Package] Components
/packages/components
[Tool] ESLint plugin
/packages/eslint-plugin
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #30503 (comment).
The first step in removing
@emotion/css
and replacing it with@emotion/styled
and@emotion/react
.How has this been tested?
ESLint errors should appear for
@emotion/css
. The existing errors should all be disabled (with a comment explaining that the import will be removed as part of #30503 (comment))Types of changes
New feature.
Checklist:
*.native.js
files for terms that need renaming or removal).