Fix incorrect useCustomUnits import #32248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copons
added
[Type] Bug
Copons
requested review from
mattwiebe,
aristath,
vindl,
creativecoder,
david-szabo97,
jeyip and
Addison-Stavlo
|
Size Change: 0 B Total Size: 1.86 MB ℹ️ View Unchanged
|
creativecoder
approved these changes
May 26, 2021
david-szabo97
approved these changes
May 27, 2021
aristath
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #31822 we moved
useCustomUnitsto a different package, and exported it as__experimentalUseCustomUnits.There is one case where the hook is incorrectly imported without the
__experimentalpart, which causes some crashes in the Site Editor (see testing instructions).This PR simply fixes the import adding the
__experimentalpart.How has this been tested?
To reproduce the crashes:
Try again with this PR: you should be able to open the Global Style's Site Title section.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).