Change default context of the block editor settings API endpoint #31538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gziolo 👋 I assigned you as a reviewer to double-check if this should be the default context if none is passed to the API endpoint. What do you think? |
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
I'm curious how would it work in practice? Would it try to collect all possible settings or only a shared subset of settings? What about filters that plugins and sites can apply? |
Actually, I thought of this when I was having issues with the I'll close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the default context for this endpoint to be
allinstead ofpost-editorHow has this been tested?
Test the endpoint
/wp-json/__experimental/wp-block-editor/v1/settingsAnd expect to return the default settings.
Types of changes
Small fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).