Fix mover position. #30242
Merged
Fix mover position. #30242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +60 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Mar 26, 2021
| @@ -556,7 +556,8 @@ | |||
|
|
|||
| // Position mover arrows for both toolbars. | |||
| .block-editor-block-contextual-toolbar, | |||
| .edit-post-header-toolbar__block-toolbar { | |||
| .edit-post-header-toolbar__block-toolbar, | |||
| .edit-site-header-toolbar__block-toolbar { | |||
There was a problem hiding this comment.
Not something for this PR, I can follow up, but I just realised this is where we probably also need edit-widgets-header__block-toolbar and edit-navigation-layout__block-toolbar. Hopefully that would solve some of the issues that have been seen.
It doesn't seem completely sustainable to style the toolbar using these classnames. It ties in with an issue I made - #29965. But not something to worry about right now.
There was a problem hiding this comment.
Thanks so much for the review.
I profoundly agree it's not sustainable. I forgive the current situation because the dedicated site editor as a separate menu item was created in order to experiment. But as we move forward and if we decide to keep that separate menu item, we need to find a better way to do that. This separate PR I worked on is an example of that: #30234 — the markup deviates quite a bit, and it's painful to keep in sync; features or bugfixes for one editor built for one are likely to be missing from the other due to this mix.
There was a problem hiding this comment.
Oh sorry, I just merged with the big green button — let me follow up with a PR with your suggestion.
7 tasks
paaljoachim
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The movers were not positioned right:
This PR fixes that, and an issue for the site editor:
How has this been tested?
Please test the mover control in post and site editor, mobile and desktop, top toolbar on and off, and verify it all looks good.
Checklist: