Revert moving is-typing class #29608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
Size Change: +11 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Great! Seems like it would be good to have some navigation block e2e tests. |
Yes, that's next :D I'm working on re-enabling them in #29543 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #29391.
Introduced by #29186.
Alternative to #29596: there's no need to revert the whole commit.
Fixes an error in the navigation block if you type in a child block. Partly reverts #29186. Somehow moving the
is-typingclass causes the problem, but I haven't tracked down why it causes an infinite loop.How has this been tested?
Screenshots
Types of changes
Checklist: