Make parent block selector visible and offset the toolbar. #28598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -28 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
mtias
force-pushed
the
update/visible-parent-selector
branch
from
a6cc643 to
da52974
Compare
mtias
added
the
[Feature] Nested / Inner Blocks
|
We've tried many things: the parent pop-out chip, clickthrough, breadcrumbs, the block traversal tool. Some are still around, others were not succesful. Because it's such an important tool, it's important to continue refining this interface. And this feels like a natural evolution of the parent pop-out chip, probably why it's already been proposed and discussed. The benefits remain:
Downsides remain:
However, since the original conversations, a few changes have been made which makes me think it's time to try it:
And in practice this change really does improve things. Notably the hover block boundary indication is highly helpful in indicating the behavior. Cover:
A paragraph inside a default group (fixes #20453):
Columns benefit vastly:
Navigation benefits:
I think there's still there's work to do separately. Notably the width of the block mover/drag control adds weight to child block toolbars, and in that the option doesn't work with the "top toolbar" option, it seems like there might be an opportunity to explore a solution that tackles both. Finally, blocks with already wide toolbars, such as List, will either need nesting (to split the long toolbar into parent and child) or other thought (group tools in dropdowns). But all of those followups are general benefits to the block UI, and ultimately the benefits of this approach seem worth trying. The "Group" block example above feels like a good litmus test: before it was unobvious that the paragraph was inside an invisible group, but with the added chip, its place in the hierarchy becomes immediately obvious, and will benefit both Quote and Gallery blocks as they get nesting. 🚀 |
mtias
force-pushed
the
update/visible-parent-selector
branch
from
fdd33c9 to
fb83d1e
Compare
talldan
reviewed
Feb 2, 2021
packages/block-editor/src/components/block-list/block-contextual-toolbar.js
Outdated
Show resolved
Hide resolved
| > | ||
| <ToolbarButton | ||
| className="block-editor-block-parent-selector__button" | ||
| onClick={ () => selectBlock( firstParentClientId ) } | ||
| label={ sprintf( | ||
| /* translators: %s: Name of the block's parent. */ | ||
| __( 'Select parent (%s)' ), | ||
| __( 'Select %s' ), |
There was a problem hiding this comment.
In #26135 this change was also proposed, but I don't think it's a good idea for situations where a block might be nested in same block type - e.g. a group within a group. That seems very confusing, I think it's probably quite confusing already with the icon being the same as the block icon.
Are there other options? I proposed just making it 'Select parent'. Alternatively could the text wrap in the text labels mode?
cc @tellthemachines.
There was a problem hiding this comment.
I think the same block nested within itself is enough of a special case that we might just as well treat that one separately. "Select parent" is rather technical and cumbersome for most cases (for example, selecting the Gallery that contains an Image, or the Quote that has a paragraph, etc). I think all of these cases benefit from a more straightforward phrasing.
Co-authored-by: Miguel Fonseca <[email protected]>
mtias
force-pushed
the
update/visible-parent-selector
branch
from
a92eced to
b447787
Compare
|
🔥 |
|
I'm guessing this change wasn't tested with text labels enabled:
Text labels have variable widths, so fixing this will require removing the absolute positioning on the parent button, which also means we'll have to set the background and borders on the toolbar elements instead of the parent, to keep that little separation between parent button and the rest of the toolbar. |
|
Sorry about that one, I'll try and follow with a PR. |
6 tasks
|
Fix in #28721. |
|
Oh my, I was convinced we had not yet applied the text only treatment to the contextual block toolbar. |
|
I made sure to get it in for 5.7, as it felt weird to just have text labels in the top toolbar 😄 Thanks for the quick fix @jasmussen ! |
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28522.
Complements #23800.
Parent highlighting outline:
Current block highlighting outline: