Polish Buttons block radius, and size. #28514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +35 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
jasmussen
force-pushed
the
try/button-radius
branch
from
06faffb to
43c4864
Compare
|
This looks good. I've tested in a few themes and I don't see any issues. |
|
Is this PR still valid after the other changes in buttons styles like: #28485? |
|
Yes, it's still valid, but it needs a good rebase. The focus of this PR is to fix the border radius (roundness), which is a little off currently, and the size of a solid and outline button side by side, which is also off. But because it's a bit more of an "opinionated" PR, I'm not sure it's urgent to land. There's a teensy bit more risk associated with this one. |
jasmussen
force-pushed
the
try/button-radius
branch
from
43c4864 to
3f78961
Compare
|
Rebased. The before and after remain the same. Notice how the two buttons in the following "before" are not perfectly pill shaped, and that the outline version is slightly taller than the solid version:
This PR fixes both those issues with a perfect pill shape and identical height:
|
|
Alright, this one is not for 5.7, but it might be good to land now post 5.7. CC: @WordPress/gutenberg-core |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buttons do not have the correct radius, and the solid button is smaller than the outline button. This PR fixes both. Before:
Note: the "space-between" effect is a separate bug, fixed in #28485
After:
Here's what changed:
2px solidis the same as2px solid currentColor, the latter is just easier to understand).I would very much like to retire the specific gray color for the solid button, but this has to be a separate global styles effort.
This PR needs a great deal of sanity checking especially from theme developers, as although the changes are small, they do affect shipping code.