Make sure toggleProps doesn't replace important props on ToolbarGroup #28401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegohaz
added
[Package] Components
|
Size Change: -4 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #26135.
When we do this:
renderDropdownMenuwill receiveinternalTogglePropsfromToolbarItemso the toggle button can work as a roving tabindex item. The way it's done today — by merging the incomingtogglePropswithinternalTogglePropsusing object spread — might result intogglePropsreplacing important props passed byToolbarItem, like event handlers etc.Instead, we can just pass
togglePropstoToolbarItem, which will already handle those cases, by merging event handlers and other props properly.This PR is not fixing any existing issues, but preventing them from happening in the future.
cc/ @tellthemachines Could you please check if your changes on #26135 still work with this PR?