Post Title block: Add placeholder state #28198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +410 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
david-szabo97
requested review from
jameskoster,
vindl,
noahtallen,
mattwiebe,
Addison-Stavlo,
Copons,
jeyip and
mtias
|
Works as advertised! :) Do you think it would be good to update the actual placeholder content and the block name / description (as outlined here) in this PR? Or to do that separately? |
| { ...( isLink ? {} : blockProps ) } | ||
| /> | ||
| <TagName { ...( isLink ? {} : blockProps ) }> | ||
| { __( 'Placeholder for post title' ) } |
There was a problem hiding this comment.
I wonder if there's a better way to convey this... Maybe something like:
Post title (placeholder)
I also wonder if we can contextualize this placeholder to the actual postType; So if I'm editing a Page it would say Page title (placeholder).
There was a problem hiding this comment.
What do you think about what @jameskoster was proposing in his issue linked above - An example title
There was a problem hiding this comment.
I think it may be worth spending some more time exploring designs for this, and accounting for all different block types. I wouldn't say it needs to hold up this PR.
|
Addison-Stavlo
approved these changes
Jan 20, 2021
jameskoster
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a "placeholder state" for Post Title block. This state is shown when Post Title block is outside of Query block or any other context that could provide an entity for the block.
Fixes #27029
Related #19256
How has this been tested?
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Checklist: