Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/refactor inserter #28181

Closed
wants to merge 3 commits into from
Closed

Update/refactor inserter #28181

wants to merge 3 commits into from

Conversation

jhnstn
Copy link
Contributor

@jhnstn jhnstn commented Jan 14, 2021

Description

Part of #22890. Refactor the 'Inserter' component to a functional component using hooks.

How has this been tested?

Manually tested to make sure URL input behavior is consistent with existing behavior using #24089 as a guide.

Types of changes

Refactored to use functional component.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@jhnstn jhnstn requested a review from ellatrix as a code owner January 14, 2021 01:54
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 14, 2021
@jhnstn jhnstn closed this Jan 21, 2021
@jhnstn
Copy link
Contributor Author

jhnstn commented Jan 25, 2021

Closed due to recent file changes causing a conflict. I'm also putting the work on hold to concentrate on higher priority issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant