Block editor: refactor effect.js to controls #27298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
requested review from
ajitbohra,
chrisvanpatten,
ellatrix and
mkaz
as code owners
|
Size Change: +32 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
adamziel
changed the title
adamziel
changed the title
adamziel
added
[Package] Block editor
adamziel
force-pushed
the
try/effects-js-block-editor
branch
from
3b3917c to
ebc5b7d
Compare
|
@tyxla would you mind reviewing? E2E failures here are consistent with ones on |
|
So It's surprising to see that the size of the bundle doesn't decrease though: |
8 tasks
gziolo
approved these changes
Dec 1, 2020
There was a problem hiding this comment.
I'm not the best person to approve this PR as I know little about side effects in the block editor, but based on my limited knowledge changes proposed look good. All tests pass which is the most important indicator here.
I would appreciate some cross-check from someone else.
| 'getSelectedBlockCount' | ||
| ); | ||
|
|
||
| speak( |
There was a problem hiding this comment.
It isn't clear when we use controls in actions. Technically speaking speak is also a side effect, although it definitely isn't something that you need to wait for. I see that it's inlined the same way in other places so it might be may misunderstanding when to use controls.
tyxla
approved these changes
Dec 4, 2020
|
Those tests shouldn't fail anymore after the rebase. I can't guarantee something else will fail though. The stability of e2e tests isn't ideal with the constantly growing number of contributions :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the
block-editorstore effects into controls. See #27069 and #26866.That allows us to also remove
refxas a middleware for side effects, which this PR is also taking care of.How has this been tested?
Types of changes
Non-breaking code quality enhancement.
Checklist: