Interface: Add deprecation logic for leftSidebar prop #26826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
ajitbohra,
chrisvanpatten and
mkaz
as code owners
gziolo
force-pushed
the
update/interface-skeleton-deprecation
branch
from
444a83a to
6fa03f3
Compare
6 tasks
gziolo
commented
Nov 9, 2020
| @@ -2,280 +2,285 @@ | |||
|
|
|||
| For features included in the Gutenberg plugin, the deprecation policy is intended to support backward compatibility for two minor plugin releases, when possible. Features and code included in a stable release of WordPress are not included in this deprecation timeline, and are instead subject to the [versioning policies of the WordPress project](https://make.wordpress.org/core/handbook/about/release-cycle/version-numbering/). The current deprecations are listed below and are grouped by _the version at which they will be removed completely_. If your plugin depends on these behaviors, you must update to the recommended alternative before the noted version. | |||
|
|
|||
| ## 9.7.0 | |||
There was a problem hiding this comment.
Pretttier triggered the update to many existing lines 😅
Ignoring whitespace should help:
https://github.com/WordPress/gutenberg/pull/26826/files?diff=unified&w=1
There was a problem hiding this comment.
I'm wondering though why the whitespace changes triggered now and not sooner...
There was a problem hiding this comment.
We never executed Prettier on .md files, but I wouldn't mind personally doing so.
@mkaz, how do you feel about this idea?
|
Size Change: +288 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a change introduced to the
InterfaceSkeletonpage in #26517. While it shouldn't have any impact on Gutenberg itself, I thought it would be good to start with a deprecation for those who consume@wordpress/interfacepackage from npm. I proposed a deprecation that would get removed from the plugin (and the package) in a few weeks.