Fix RTL e2e tests #26508
Merged
Fix RTL e2e tests #26508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Automated Testing
ellatrix
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
|
I'm happy to approve this as it seems good to me, and by all accounts it just needs approval from Travis above. |
|
Size Change: +151 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
|
Ok, so now all RTL tests fail on Travis but pass locally, which sounds like a failure to switch languages on a clean install. Maybe it has do to with loading the language packs? |
|
Anecdotally, tests have failed for me all week, on all 7 of my open PRs. So I think there's something else going on too. |
ellatrix
commented
Oct 27, 2020
| @@ -15,10 +15,12 @@ const ARABIC_TWO = '٢'; | |||
| describe( 'RTL', () => { | |||
| beforeEach( async () => { | |||
| await createNewPost(); | |||
| await page.evaluate( () => { | |||
| document.querySelector( '.is-root-container' ).dir = 'rtl'; | |||
There was a problem hiding this comment.
So it seems reducing the scope of the layout shift is solving the issue. We're just testing rich text and writing flow here, so that's fine.
There was a problem hiding this comment.
That is weird but I guess it's better than having wrong snapshots :)
youknowriad
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores snapshots that were altered in #22213. I'm unsure what caused the failures, especially since it was a minor CSS change. After trial and error this method of changing the site language entirely seems much more robust.