Fix search suggestions in WordPress Core #25934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force fetchLinkSuggestions() to always set type=post when the JavaScript has been bundled for use in WordPress Core. This is because WordPress Core does not yet have the necesasry PHP to support specifying type=term or type=post-format in /wp/v2/search.
noisysocks
added
REST API Interaction
|
I don't really have an issue committing https://core.trac.wordpress.org/ticket/51458 now if we want to do that. |
|
Yeah? And |
|
Yeah seems fine to me. They're stable. Are there any changes to it planned in 5.6? |
|
No changes planned that I'm aware of. They won't be used by anything, though 🙂 But if you're happy then I'm happy! |
|
Size Change: 0 B Total Size: 1.18 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force
fetchLinkSuggestions()to always settype=postwhen the JavaScript has been bundled for use in WordPress Core. This is because WordPress Core does not yet have the necesasry PHP to support specifyingtype=termortype=post-formatin/wp/v2/search.This check can be removed when the PHP added in #22600 has been committed to WordPress Core.
cc. @tellthemachines