Revert "[Try] Customizable toolbar contents (#23613)" #25854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Task
|
Size Change: -5.69 kB (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
Closed
11 tasks
|
Not a blocker by any means, but just noting reverting these changes would also revert this nice side-effect of having CSS transitions in place:
I quite enjoyed the aesthetics of smooth resizing (vs instant change) so just flagging it here. CC @shaunandrews @mapk, maybe it would inspire some future work. |
|
Should it be merged or closed now that a few weeks passed? 😃 |
|
@talldan this has conflicts now, would you solve them and ping me? Let's get this PR in. |
talldan
force-pushed
the
revert/customizable-toolbar
branch
2 times, most recently
from
951c70c to
64a400f
Compare
This reverts commit 5078c43.
talldan
force-pushed
the
revert/customizable-toolbar
branch
from
64a400f to
e92e0ec
Compare
|
Rebased! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5078c43.
Description
Reverts the API introduced in #23613, which will be superseded by #25890.
While there's still a desire to add in-toolbar editing of items (Linking #23375, Image cropping), the approach taken in that PR isn't accessible as it replaces the DOM and results in focus loss.
I don't see a way to rework this existing API to be accessible, so I think it's best to start from scratch with something new.
This API is currently unused, so there should be no issue reverting.