Document Actions: Use page name for header info section #25594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
added
[Type] Enhancement
|
Size Change: -7 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
noahtallen
commented
Sep 24, 2020
| @@ -147,6 +148,7 @@ export function* showHomepage() { | |||
|
|
|||
| const page = { | |||
| path: '/', | |||
| label: showOnFront === 'page' ? __( 'Homepage' ) : __( 'All Posts' ), | |||
There was a problem hiding this comment.
could just change this to homepage. (and then also update that in the page selector)
|
We are not moving forward with this for the time being (will look back into it after "template editing" is better developed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the page name for the header info section. The "page name" here means the label for the "active site page" in the site editor. So for a page/post, it will be the page/post title. For the category, it would be the category name.
resolves #25546
How has this been tested?
Locally in edit site.
Screenshots
Types of changes
Enhancement.
Checklist: