Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change navigation block description #25531

Merged
merged 9 commits into from
Sep 23, 2020

Conversation

devfle
Copy link
Contributor

@devfle devfle commented Sep 22, 2020

Description

Fixes #25013 - In this PR I changed the description of the navigation block.

How has this been tested?

I have uploaded the changes on my local Wordpress installation and checked the changes. Everything worked fine.

Screenshots

Before:
before

After:
after

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the only thing that needs fixed is coding standards 👍

packages/block-library/src/navigation/index.js Outdated Show resolved Hide resolved
packages/block-library/src/navigation/index.js Outdated Show resolved Hide resolved
packages/block-library/src/navigation/index.js Outdated Show resolved Hide resolved
packages/block-library/src/navigation/index.js Outdated Show resolved Hide resolved
packages/block-library/src/navigation/index.js Outdated Show resolved Hide resolved
packages/block-library/src/navigation/index.js Outdated Show resolved Hide resolved
packages/block-library/src/navigation/index.js Outdated Show resolved Hide resolved
packages/block-library/src/navigation/index.js Outdated Show resolved Hide resolved
@devfle
Copy link
Contributor Author

devfle commented Sep 22, 2020

Hmm..! That comes from my VS-Code Prettier. I will fix this. Thank you!

Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes :)
LGTM 👍

@aristath aristath merged commit 99bff62 into WordPress:master Sep 23, 2020
@github-actions github-actions bot added this to the Gutenberg 9.1 milestone Sep 23, 2020
@david-szabo97 david-szabo97 mentioned this pull request Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Navigation block's description
2 participants