[RNMobile] Update color retrieval from settings to useEditorFeature #25519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronvoell
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
|
Should we also add the removed default colors and gradients to |
chipsnyder
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
Ran through the regression steps for editor theme
- ✖️Default Colors - Check that default colors still load - steps
- ✖️Default Gradients - Check that default gradients still load - steps
- ✅ Custom Colors - Check that custom colors load in the editor - steps
- ✅ Custom Gradients - Check that custom gradients load in the editor - steps
- When changing a theme if the new theme downloads before the existing one then the editor needs to be reopened before it is reflected. This is to be a known issue. - ✅ Offline Support - steps
Overall this looks good and removes the crash. I think we can handle the top two test cases in different PR so we unblock current development.
Merged
2 tasks
This is a good idea @cameronvoell I'll leave it up to you if you want to do that now or if you think that's better for another PR |
guarani
approved these changes
Sep 21, 2020
cameronvoell
changed the title
cameronvoell
deleted the
rnmobile/fix-color-settings-red-screen-cover-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GB-Mobile PR: wordpress-mobile/gutenberg-mobile#2648
Description
Fixes mobile crash on
masterafter default color settings were updated here: #25419How has this been tested?
We should test flows using default colors/gradients
We also need to make sure that custom theme still work which are set here:
gutenberg/packages/editor/src/components/provider/index.native.js
Line 127 in 5ced7f1
Screenshots
Checklist: