Don't discard all promises results when one of them rejects #25302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
reviewed
Sep 15, 2020
There was a problem hiding this comment.
Hey thanks for working on this!
I haven't checked thoroughly about Promise. allSettled current support but the Implementation Progress section doesn't make me 100% sure. (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled)
| } ); | ||
| // use allSettled to preserve any successful promise(s) results when one of the promises fail | ||
| return Promise.allSettled( queries ) | ||
| .then( ( results ) => |
There was a problem hiding this comment.
Why don't you use only one then?
| } ); | ||
| // use allSettled to preserve any successful promise(s) results when one of the promises fail | ||
| return Promise.allSettled( queries ) | ||
| .then( ( results ) => |
alshakero
changed the title
alshakero
changed the title
|
Thanks for the review @ntsekouras! I found a more supported way to fix this. |
noahtallen
reviewed
Sep 15, 2020
| @@ -66,7 +66,7 @@ const fetchLinkSuggestions = ( | |||
| type: 'post', | |||
| subtype, | |||
| } ), | |||
| } ) | |||
| } ).catch( () => [] ) // fail by returning no results | |||
There was a problem hiding this comment.
Is the error important for us to know about?
In other words, will discarding the error entirely be problematic?
There was a problem hiding this comment.
Maybe. But the failure wasn't handled before this change anyways, so there is no regression.
noahtallen
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi there!
Some blocks, such as the Link block, have a search feature for URLs. This feature searches against 3 endpoints with different query params. These searches run concurrently using
Promise.all. Good design but with one flaw, if any of the searches fail, all the results are discarded, due to the nature ofPromise.all.This PR proposes usingPromise.allSettledinstead. It resolves even if one or two promises fail out of 3. I think it makes more sense since the other two promises can provide valid results just fine.Edit: I removed
Promise.allSetteddue to the support question.This PR proposes catching each failing request and returning an empty array in the
catchhandler, denoting an empty result. This gives the chance for the other successful promises to prevail.The issue has surfaced when one of the searches started failing as shown here.
How has this been tested?
I tested using a local Gutenberg instance.
Side note
This fix is an improvement and should be probably merged anyways. But there is also an underlying issue, it's explained in this comment.
Types of changes
bug-fix
Checklist: