-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try block toolbar inline edit slot #25177
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
General Interface
Parts of the UI which don't fall neatly under other labels.
[Feature] Navigation Screen
labels
Sep 9, 2020
Size Change: -5.29 kB (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
6 tasks
I'm not able to build this branch, getting a huge dump of errors apparently related to TypeScript and SVGs, see example below. Any idea what's going wrong?
|
This reverts commit 5078c43.
talldan
force-pushed
the
try/block-toolbar-inline-edit-slot
branch
from
September 22, 2020 04:08
3da4ed1
to
ed254f8
Compare
Superseded by #25890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
General Interface
Parts of the UI which don't fall neatly under other labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts #23613 and replaces it with a 'popover' style slot as advised by the a11y team in #24021 (comment).
How does this work?
This PR introduces a new slot on the toolbar
BlockToolbarInlineEditSlot
. When this slot contains a fill, it signals to a context provider that other toolbar content should be 'visually hidden' and only the fill should be rendered.Additionally, anything rendered in the fill is wrapped in a
PopoverWrapper
(the same as the one introduced in #24429) which provides popover behaviors but is rendered inline.How has this been tested?
This PR doesn't actually implement anything visible, but I've rebased #24021 on top of this, and that's the PR should be tested.
Screenshots
Types of changes
Checklist: