Support enabling custom link color from theme.json #25148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
ellatrix,
spacedmonkey and
TimothyBJacobs
as code owners
youknowriad
added
[Type] Experimental
youknowriad
commented
Sep 8, 2020
| @@ -129,7 +129,8 @@ | |||
| "dropCap": true | |||
| }, | |||
| "color": { | |||
| "custom": true | |||
| "custom": true, | |||
| "link": false | |||
There was a problem hiding this comment.
maybe there's a better path here?
There was a problem hiding this comment.
I'm happy to approve as it is. In its current shape, the other option I can think of is making link a top-level element of features, which doesn't feel great either.
I also wonder if we should do a follow-up PR when we revisit/consolidate the features shape before releasing Gutenberg 9.0. I believe is the first release we include this feature and it'll be good to avoid changing shape later. Left some comments at #20588 (comment)
There was a problem hiding this comment.
We definitely need a follow-up PR to reshape the paths. That said, I'm not sure if it's before or after Gutenberg 9.0. The important thing is to do it before we make theme.json stable.
There was a problem hiding this comment.
It's not the first release for these things, 8.9 include one or two features and dropCap is there for a long time.
|
Size Change: -8 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
11 tasks
oandregal
reviewed
Sep 9, 2020
| }, | ||
| [] | ||
| ); | ||
| const isLinkColorEnabled = useEditorFeature( 'color.link' ); |
There was a problem hiding this comment.
I really like how the useEditorFeature simplifies the code. Can't wait to see the same done for presets.
oandregal
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #20588
Similar to #24761 but for link color.
The idea of this PR is to support disabling/enabling link color support from theme.json.
Testing instructions
link.colorpath.