Allow disabling custom font sizes using theme.json config #25038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
Customization
youknowriad
requested review from
ellatrix,
spacedmonkey and
TimothyBJacobs
as code owners
youknowriad
commented
Sep 3, 2020
| @@ -133,6 +133,9 @@ | |||
| }, | |||
| "gradient": { | |||
| "custom": true | |||
| }, | |||
| "fontSize": { | |||
There was a problem hiding this comment.
I think in other places we use font-size but it was inconsistent with other properties on the file, so I chose fontSize instead. cc @jorgefilipecosta
There was a problem hiding this comment.
I think the only place we use kebab-case for this is in the font-size preset, for historical reasons. I agree we should update that as well and join team camelCase everywhere.
|
Size Change: +12 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
11 tasks
oandregal
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #20588
Similar to #24761 but for custom font sizes.
The idea of this PR is to support disabling/enabling custom gradients from theme.json while retaining backward compatibility for the disable-custom-font-sizes theme support flag.
Testing instructions