Show inserter on click

[kirilzh]

Description

Addresses: #13571
I've removed the code responsible for showing the sibling inserter on hover. Clicking on a block will make it visible underneath the block.

How has this been tested?

Tested manually with paragraph and button group blocks.

Screenshots

Types of changes

New feature that should enhance user experience.

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[ZebulanStanphill]

Here's what I see:

I think if we go this route we should probably redesign the inserter a bit. Perhaps move the plus icon to the left, to align it with the block toolbar. Also, let's only show the line when the button is hovered/focused.

Here's a mockup of what I'm thinking:

Also, I noticed two bugs in the PR:

• When tabbing from the top toolbar, the sibling inserter is tabbed into before the block toolbar, despite visually appearing after it. This should be changed.
• The sibling inserter doesn't appear for nested blocks (e.g. those inside a Column or Group).
  

[kirilzh]

ok, so I made a few changes, I decided to start working on this from scratch.
I have a question, when the inserter line between buttons in button group should have vertical orientation, right?

[paaljoachim]

Hey @kirilzh Yes.
That sounds reasonable!

Btw
Let me know when you have the next version up and I will take it for a test.

[ZebulanStanphill]

@kirilzh Ideally, there would be a vertical line, but the current implementation in master doesn't even seem to show sibling inserters for horizontally-laid-out blocks. So I don't think there's any obligation for you to implement that missing feature in this PR, if it turns out to be really complicated to do so.

[kirilzh]

@ZebulanStanphill Yeah I guess I won't be doing the vertical lines between buttons. I don't see an easy solution with the <Popover /> component to have it positioned in a group component and have it appear horizontal or vertical based on the surrounding context.

[paaljoachim]

@kirilzh Kiril told me that he is not working on Gutenberg any longer. This also means that someone else will need to either take over this PR, or that we need to close it.

[youknowriad]

closing this PR for now. A lot of changes happen since and it's not clear how relevant this is anymore.