[Sitebars endpoint] Add tests for slashing behavior #24785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
the
[Feature] Widgets Screen
20 tasks
|
Size Change: 0 B Total Size: 1.17 MB ℹ️ View Unchanged
|
|
@adamziel the new test seems to fail. |
noisysocks
reviewed
Aug 26, 2020
| @@ -378,6 +378,60 @@ public function test_update_item() { | |||
| ); | |||
| } | |||
|
|
|||
| /** | |||
| * | |||
There was a problem hiding this comment.
Please write something here.
adamziel
force-pushed
the
update/test-slashing-behavior
branch
3 times, most recently
from
1abeb61 to
6f73eda
Compare
|
The test fails because of ">" character in the input. It should most definitely be addressed, but is not trivial and it also seems out of scope for this PR. I removed this case from here and added another task to the list. |
|
Would you mind re-reviewing @draganescu? |
Which issue # is that? |
|
@TimothyBJacobs I was lazy and added it to the list in this issue to address later this week :) #24530 :
|
|
Got it! |
noisysocks
approved these changes
Aug 27, 2020
adamziel
force-pushed
the
update/test-slashing-behavior
branch
from
6f73eda to
c11eabd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds coverage for the correct usage of
wp_slashinupdate_itemmethod as per #24290 (review).How has this been tested?
Confirm all checks pass on this PR.
Types of changes
Non-breaking change
Checklist: