-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[InputControl] Add prefix prop #23824
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
the
[Feature] UI Components
Impacts or related to the UI component system
label
Jul 9, 2020
adamziel
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
July 9, 2020 11:41
adamziel
changed the title
[Input control] Add prefix prop
[Input Control] Add prefix prop
Jul 9, 2020
adamziel
changed the title
[Input Control] Add prefix prop
[InputControl] Add prefix prop
Jul 9, 2020
Size Change: +54 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Yay! Thanks for this! It looks like it was relatively easy to do 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
prefix
property to the InputControl component. The implementation is pretty straightforward - it's just a counterpart of the already existingsuffix
property. The need was created by the following design from #23375How has this been tested?
npm run storybook:dev
)Screenshots
Checklist: