Show a warning when SlotFillProvider is missing #23493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegohaz
requested review from
ajitbohra,
chrisvanpatten,
ellatrix and
youknowriad
as code owners
diegohaz
added
[Package] Components
|
Size Change: +979 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Jun 26, 2020
| @@ -4,6 +4,7 @@ | |||
| import { createContext } from '@wordpress/element'; | |||
|
|
|||
| const SlotFillContext = createContext( { | |||
| __unstableDefaultContext: true, | |||
| slots: {}, | |||
| fills: {}, | |||
| registerSlot: () => {}, | |||
There was a problem hiding this comment.
Could we warn instead when the default function that registers slots is called? This way we would avoid introducing the unstable property and the warning would fire in almost the same place.
I’m suggesting moving the warning call to registerSlot. What do you think?
There was a problem hiding this comment.
This makes a lot more sense. Will make the change.
|
Thanks for opening this PR. I had one minor consideration but we overall this PR looks good 👍 |
gziolo
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #23388
Here I'm only adding a warning on the
Slotcomponent, and not on theuseSlothook.SlotFillProviderandSlotare optional for some components that calluseSlot. For example,Popoverwill render its contents within aFillcomponent only ifSlotandSlotFillProviderare present:gutenberg/packages/components/src/popover/index.js
Lines 590 to 592 in f9543e7
I also updated the
@wordpress/block-editorpackage README, as it was causing confusion when people just copied and pasted the example code.How to test?