Add preset for padding and use it in the UI controls #23176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
oandregal
added
[Feature] Design Tools
|
Size Change: -276 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
oandregal
changed the title
oandregal
commented
Jun 16, 2020
| @@ -131,6 +132,12 @@ export const SETTINGS_DEFAULTS = { | |||
| { slug: 'full', name: __( 'Full Size' ) }, | |||
| ], | |||
|
|
|||
| padding: [ | |||
There was a problem hiding this comment.
cc @mapk @kjellr @jasmussen I'm still working on this one, but I thought I'd ping early. What do you think of these default values? Would you use a different combination?
There was a problem hiding this comment.
I'd go in multiples of 4 if we go with pixels or even another unit. I'm wondering if rem units might be better here.
As far as pixel values
small: 4 - nice
regular: 16
large: 32 - only large relative to body copy, though
Em units could also work well and more flexibly even if they are harder to understand. If so, maybe:
small: .5em
regular: 1em
large: 1.5em
There was a problem hiding this comment.
Thanks, Michael! I pushed those defaults. I also wanted to say that this PR is going to hibernate for a bit as there are some design and engineering issues we need to fix before being able to land it (so it's not going to be part of 5.5 -- sorry about the confusion!).
oandregal
added
the
Global Styles
oandregal
force-pushed
the
add/preset-padding
branch
from
adce1ae to
76c4daa
Compare
This reverts commit cf2685f. See conversation at #23177 (comment)
oandregal
force-pushed
the
add/preset-padding
branch
from
76c4daa to
f9720d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #23111
This PR adds a new preset for padding that themes can use similar to how they use colors, font-sizes, and gradients.
TODO: