-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Drag and Drop in Safari by upgrading Reakit #22960
Conversation
Size Change: +803 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code ✅
Someone else should also confirm that it tests well 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Safari on 13.1 on macOS Catalina 10.15.4. Drag-and-drop and clicking buttons in the heading level toolbar both work.
Thanks for the fix @diegohaz ! |
This PR upgrades
reakit
and fixes #22730 so drag and drop works in Safari again.Changelog
1.0.4 (2020-06-06)
Bug Fixes
Tabbable
preventing drag events on mouse down on Safari (#670) (6830c5a)1.0.3 (2020-06-04)
Bug Fixes
Tabbable
on Safari and Firefox on MacOS (#658) (aad12ce)Performance Improvements
Composite
performance (#660) (f6656b6)Before
After
Also, the workaround on the Heading level control dropdown is no longer necessary (cc @ZebulanStanphill):
How to test