Make reusable block e2e tests independent. #21985
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainthkh
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
sainthkh
commented
Apr 30, 2020
| @@ -165,40 +209,19 @@ describe( 'Reusable blocks', () => { | |||
| } ); | |||
|
|
|||
| it( 'can be inserted after refresh', async () => { | |||
There was a problem hiding this comment.
After investigating, I learned that can be inserted and edited and can be inserted after refresh are different tests.
can be inserted and editedfocuses on testing creating and editing in one writing session.can be inserted after refreshfocuses on testing the reusable block is saved correctly to the database and loaded without fail when writing a new post or editing existing ones.
sainthkh
force-pushed
the
fix/reusable-block-test
branch
from
ebd5aa5 to
8d0d9a9
Compare
sainthkh
force-pushed
the
fix/reusable-block-test
branch
from
a40bf8c to
0f11258
Compare
sainthkh
commented
May 1, 2020
Comment on lines
+23
to
+26
| // When no reusable block is registered, return | ||
| if ( ( await page.$x( '//td[text()="No blocks found."]' ) ) !== null ) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
It was a bit hard to find that this case was failing the tests.
|
@noisysocks It's ready for review. This PR:
|
|
Thanks for your work here. For some reason, I missed this PR :( I did an extensive refactor to this test a few weeks ago and I believe it's now based on independent tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made reusable block e2e tests independent.
How has this been tested?
e2e tested with code.
Screenshots
N/A
Types of changes
Bug fix
Checklist: