Add font size control for heading block #21431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
oandregal
changed the title
oandregal
added
the
Global Styles
|
Size Change: +6 B (0%) Total Size: 889 kB
ℹ️ View Unchanged
|
youknowriad
reviewed
Apr 6, 2020
oandregal
force-pushed
the
add/font-size-headings
branch
from
2f2a1a4 to
43e94ca
Compare
youknowriad
approved these changes
Apr 8, 2020
oandregal
force-pushed
the
add/font-size-headings
branch
from
43e94ca to
c947ffa
Compare
The best ones! |
|
@nosolosw Is there a way to define different preset values for different blocks? For example, is it possible to have the preset size values of the Heading block different than the preset size values of the Paragraph block? Currently, the Large and Huge values for the Heading Block are smaller than their default one, which is surprising for the user. |
That's on the roadmap, but it's not yet implemented.
This is something that is theme-specific, so it depends on the font-sizes themes add + how they decide to style the heading elements that don't have any style assigned yet (the default). I've checked TwentyNineteen and TwentyTwenty and both seem to do what you report. Were those the themes you tested? If so, perhaps it's best to search and comment on their issue tracker (twenty-nineteen, twenty-twenty). I hope this is helpful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #21428 which should land first.
This PR adds support for font-sizes at the heading block by leveraging the font size support key recently landed at #21153
How to test