Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update entity saved states to be selected by default and partitioned by type. #21159

Merged
merged 28 commits into from
Apr 2, 2020
Merged

Update entity saved states to be selected by default and partitioned by type. #21159

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
e327d5e
filter ignoredForSave out of dirtyEntityRecords
Addison-Stavlo Mar 25, 2020
81010ad
rename unsavedEntityRecords, too confusing and non-representative
Addison-Stavlo Mar 25, 2020
548a3d1
removed temporary commenting
Addison-Stavlo Mar 25, 2020
55e1330
partitioned entities by type
Addison-Stavlo Mar 25, 2020
085025a
renaming
Addison-Stavlo Mar 25, 2020
8df4aae
updated h# for entity type
Addison-Stavlo Mar 26, 2020
e555fe0
updated title to show Untitled if not present
Addison-Stavlo Mar 26, 2020
b615acd
changed prop names for interior component
Addison-Stavlo Mar 26, 2020
461a008
removed ignoredForSave prop
Addison-Stavlo Mar 27, 2020
0bafed2
started e2e test
Addison-Stavlo Mar 31, 2020
e79de94
inserted new template
Addison-Stavlo Mar 31, 2020
e397ccb
added empty string default for slug/theme name
Addison-Stavlo Mar 31, 2020
87889a5
tests for button dot state added
Addison-Stavlo Mar 31, 2020
9dceb5d
refactored test names/describes
Addison-Stavlo Mar 31, 2020
166ccc4
fixed failing test after openning button
Addison-Stavlo Mar 31, 2020
18771c6
started published checks
Addison-Stavlo Mar 31, 2020
dd35a6f
refactored reusable assertions
Addison-Stavlo Mar 31, 2020
f60e1fd
fixed last post editor test
Addison-Stavlo Mar 31, 2020
0d89553
fixed useCallback warning
Addison-Stavlo Mar 31, 2020
012702d
updated save button classname
Addison-Stavlo Apr 1, 2020
380c292
renamed test file
Addison-Stavlo Apr 1, 2020
c4c7f7d
refactored selectors etc.
Addison-Stavlo Apr 1, 2020
6cfd317
fixed undefined key in site editor
Addison-Stavlo Apr 1, 2020
18447e2
removed comment
Addison-Stavlo Apr 1, 2020
fd4da45
moved test file
Addison-Stavlo Apr 1, 2020
7c52693
added title to dirty entity selector
Addison-Stavlo Apr 1, 2020
20a4606
added getTitle to site entity
Addison-Stavlo Apr 1, 2020
9bac85a
Skip site editor tests
youknowriad Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core-data/src/selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ export const __experimentalGetDirtyEntityRecords = createSelector(
entity.key || DEFAULT_ENTITY_KEY
],
title: ! entity.getTitle
? ''
? entityRecord.title || ''
Addison-Stavlo marked this conversation as resolved.
Show resolved Hide resolved
: entity.getTitle( entityRecord ),
name,
kind,
Expand Down