Ensure that all block fixtures end with newlines #2034
Conversation
There was a problem hiding this comment.
Verified that there are no modified files when running:
gutenberg (fix/block-fixtures-newlines) $ npx rimraf blocks/test/fixtures/*.serialized.html
gutenberg (fix/block-fixtures-newlines) $ npx rimraf blocks/test/fixtures/*.json
gutenberg (fix/block-fixtures-newlines) $ GENERATE_MISSING_FIXTURES=y npm run test-unit
| const serializedActual = serialize( blocksActual ); | ||
| // `serialize` doesn't have a trailing newline, but the fixture | ||
| // files should. | ||
| const serializedActual = serialize( blocksActual ) + '\n'; |
There was a problem hiding this comment.
Should we trim here in case serialize changes in the future to add its own trailing newline or... update this logic if/when that time comes?
There was a problem hiding this comment.
Update when the time comes; require an exact match so that we know if this behavior changes.
I think the current behavior is correct for post_content, FWIW.
|
Eh, probably should have waited for the CI build to pass before merging, but I did the same verification locally. |
|
In following up on #1929 (comment), I'm finding that |
|
|
I suppose this is because the initial HTML files contain a trailing newline, and so we should remove the |
Enable Cover Block for Production
Follow-up to #1929. The whitespace in these fixture files has been flipping back and forth a bit, let's put a stop to that.