Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using DOMRect constructor for Edge and IE #20103

Closed
wants to merge 1 commit into from

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Feb 7, 2020

Description

Fixes #19979. Not sure if this is the solution we want, but it does get rid of calling DOMRect.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ellatrix ellatrix added [Type] Bug An existing feature does not function as intended Browser Issues Issues or PRs that are related to browser specific problems labels Feb 7, 2020
@ellatrix
Copy link
Member Author

ellatrix commented Feb 7, 2020

@aduth I'm guessing you prefer the polyfill? :)

@aduth
Copy link
Member

aduth commented Feb 7, 2020

@ellatrix I’ve no preference for it if it can be easily avoided to remove DOMRect. I’m mobile currently but can check later if it’s simple enough to use plain objects. I’d wonder what purpose DOMRect would otherwise serve, or were just not using those features?

@aduth
Copy link
Member

aduth commented Feb 7, 2020

I'm struggling to see what might have been the original purpose to use DOMRect, other than as a known interface of properties (which can be helpful for type-checking, certainly).

https://developer.mozilla.org/en-US/docs/Web/API/DOMRect

I guess the only worry there would be is if we're passing around these rect objects to anything which explicitly requires instanceof DOMRect.

@aduth
Copy link
Member

aduth commented Feb 7, 2020

Polyfill alternative approach is at #20110

@ellatrix ellatrix closed this Feb 10, 2020
@ellatrix ellatrix deleted the fix/domrect-edge-ie branch February 10, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block Editor: ⨁ icon and Block toolbar are missing in Microsoft Edge 18
2 participants